feat(config): override use cwd for root #86
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajaymamtora
changed the title
Ajaymamtora
changed the title
|
This PR is stale because it has been open 30 days with no activity. |
|
. |
|
This PR is stale because it has been open 30 days with no activity. |
|
. |
|
This PR is stale because it has been open 30 days with no activity. |
|
. |
|
This PR is stale because it has been open 30 days with no activity. |
|
. |
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR is stale because it has been open 30 days with no activity. |
|
. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default behaviour of this plugin is not immediately obvious, it searches outside the CWD of nvim when searching for your local config file. I had a local config that defines LSP paths in the parent folder of the CWD for my work repos. This meant that when I opened a folder underneath this folder, neoconf would find the local config and the relative file paths I'd defined in my local config were invalid because they were relative to the parent dir.
For example, I'd defined angularls probe locations.
#61
It would be good to provide an option that stops this behaviour and limiting the search to the cwd.
Ive been using code in my fork for a few weeks and have had no issues.
Related Issue(s)
This fixes #61
Screenshots