fix(cmdline): dont restore cursor after render. Fixes #959

folke · Dec 5, 2024 · c49a4b0 · c49a4b0
1 parent d9991ca
commit c49a4b0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 21 deletions.
diff --git a/lua/noice/ui/cmdline.lua b/lua/noice/ui/cmdline.lua
@@ -233,15 +233,7 @@ function M.fix_cursor()
   if not win or not M.real_cursor then
     return
   end
-  local cursor = { vim.api.nvim_buf_line_count(M.position.buf), M.position.cursor }
-  vim.api.nvim_win_set_cursor(win, cursor)
-  local leftcol = math.max(cursor[2] - vim.api.nvim_win_get_width(win) + 1, 0)
-  local view = vim.api.nvim_win_call(win, vim.fn.winsaveview)
-  if view.leftcol ~= leftcol then
-    vim.api.nvim_win_call(win, function()
-      vim.fn.winrestview({ leftcol = leftcol })
-    end)
-  end
+  vim.api.nvim_win_set_cursor(win, { vim.api.nvim_buf_line_count(M.position.buf), M.position.cursor })
   vim.api.nvim__redraw({ cursor = true, win = win, flush = true })
 end
 

diff --git a/lua/noice/view/init.lua b/lua/noice/view/init.lua
@@ -265,13 +265,6 @@ function View:render(buf, opts)
   vim.api.nvim_buf_clear_namespace(buf, Config.ns, linenr - 1, -1)
   Message._buf_messages[buf] = {}
 
-  ---@type number?
-  local win = vim.fn.bufwinid(buf)
-  if win == -1 then
-    win = nil
-  end
-  local cursor = win and vim.api.nvim_win_get_cursor(win)
-
   if not opts.highlight then
     vim.api.nvim_buf_set_lines(buf, linenr - 1, -1, false, {})
   end
@@ -284,11 +277,6 @@ function View:render(buf, opts)
     end
     linenr = linenr + m:height()
   end
-
-  if cursor then
-    -- restore cursor
-    pcall(vim.api.nvim_win_set_cursor, win, cursor)
-  end
 end
 
 return View