perf(message): replace vim.b.messages with lua variable #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrzejboczar
changed the title
|
Damn, that's crazy! ty! |
folke
pushed a commit
that referenced
this pull request
Jul 15, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.2](v4.4.1...v4.4.2) (2024-07-15) ### Performance Improvements * **message:** replace vim.b.messages with lua variable ([#898](#898)) ([7ecc05d](7ecc05d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
vim.bvariables seems slow for big tables. This PR improves performance of command output redirection (and possibly other places). From my tests this is an order of 20 sec -> 4 sec.Also, it looks like the current code sometimes assumes that
vim.b[buf].messagesis a list of buffers, while it is a list of message ids. I also changed it from a list to a set, because it's mostly used for random access.Related Issue(s)
This helps in case described here: #332 (filetype is still applied many times, but from my recent benchmarks it seems that
vim.b.messageshad bigger impact).