Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emarsys): always send cart #94

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix(emarsys): always send cart #94

merged 1 commit into from
Feb 28, 2025

Conversation

franklinkim
Copy link
Member

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch

Description

Emarsys seems to always require the cart since it's not able to combine the events by page_id

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

@franklinkim franklinkim merged commit 98399f9 into main Feb 28, 2025
2 checks passed
@franklinkim franklinkim deleted the v0.14.1 branch February 28, 2025 08:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13584106789

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 5.17%

Totals Coverage Status
Change from base Build 13583101226: 0.0%
Covered Lines: 205
Relevant Lines: 3965

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants