feat: ensure langauge server does not crash with no default export #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @codythomaszeitler! I'm so sorry for the delay, I didn't notice this PR before but until now that we have just merged a fix for the same issue 🤡 Thank you so much anyways for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It ensures that the LWC language server does not crash if an LWC file does not have a default export.
What issues does this PR fix or reference?
forcedotcom/salesforcedx-vscode#4994
So, this change works in the following way.
It assumes that the lwc language server is adding information for just the "LWC" portion of a javascript file. (the stuff included in the default export). If it does not find an LWC, it simply returns an "empty" Internal Metadata definition to the vscode language server (since no LWC implies that no metadata information should be added to the language server).