Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sort comments based on cration time by default #96

Merged
merged 2 commits into from
Apr 16, 2022
Merged

fix: sort comments based on cration time by default #96

merged 2 commits into from
Apr 16, 2022

Conversation

realaravinth
Copy link
Member

blocked by #95

@realaravinth
feat: conditionally load data from DB when updating issues and comments
38ebc62 
SUMMARY
    DBIssue and DBComment loaded data from database when performing
    updates via self.__update() which in some cases where unnecessary as a
    fetch would have been performed just before invoking __update().

    This patch introduces an optical parameter to provide recently
    loaded data from DB
@realaravinth
fix: sort comments based on cration time by default
46442cc
@realaravinth realaravinth requested a review from dat-adi April 14, 2022 18:24
@realaravinth realaravinth mentioned this pull request Apr 14, 2022
Merged
@realaravinth
Copy link
Member Author

CI failure is similar to failure in #97 but is addressed in #98, kindly ignore CI for this PR

1 similar comment
@realaravinth
Copy link
Member Author

CI failure is similar to failure in #97 but is addressed in #98, kindly ignore CI for this PR

@dat-adi dat-adi merged commit 46442cc into forgeflux-org:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dat-adi dat-adi Awaiting requested review from dat-adi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realaravinth @dat-adi