K8schaos update fix #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new release based on commit 196e078Release tag: v2.6.1-f3-196e0-k8schaos-update-take33 |
Created new release based on commit 7cf59bfRelease tag: v2.6.1-f3-7cf59-k8schaos-update-take33 |
miketonks-form3
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
From discussion recently with @rekfuki-f3 and @grahambrereton-form3 , there are some potential issues with updating resources where we update the entire object, but potentially that object has changed in the mean time, e.g. deployment.image_version
This introduces ideas around patching specific fields and merge strategies, i.e. it's a complex problem.
I don't want to block the PR some I'm approving with comments just FYI. We might need to rework at this in future if we need to update other k8s object types.
Created new release based on commit 6d795c5Release tag: v2.6.1-f3-6d795-k8schaos-update-take33 |
wvdschel-f3
force-pushed
the
k8schaos-update-take33
branch
from
5bdc21f to
35861f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous k8schaos PR had an issue where running multiple concurrent k8schaos experiments with
update=truewould cause incorrect recover behaviour.This PR should fix that.