Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add name label to chaos_experiments metric #65

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

miketonks-form3
Copy link

We need to be careful about cardinality, but since we won't have hundreds of chaos experiments it should be ok to add name, given that is really useful for dashboards and alerting

Removed the expCache to simplify code

What problem does this PR solve?

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

We need to be careful about cardinality, but since we won't have hundreds of chaos experiments
it should be ok to add name, given that is really useful for dashboards and alerting

Removed the expCache to simplify code
@miketonks-form3 miketonks-form3 requested a review from a team as a code owner December 7, 2023 18:17
Copy link

github-actions bot commented Dec 7, 2023

Created new release based on commit 4d7ad40

Release tag: v2.6.1-f3-4d7ad-mike-metrics-with-name

Link to release

@miketonks-form3 miketonks-form3 merged commit 2b56a1e into master Dec 12, 2023
47 checks passed
@miketonks-form3 miketonks-form3 deleted the mike-metrics-with-name branch December 12, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants