Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard collector #70

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

jeroenmol-form3
Copy link

Fixing:
https://github.com/form3tech/fps-gateway/issues/11663

What problem does this PR solve?

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@jeroenmol-form3 jeroenmol-form3 requested a review from a team as a code owner December 13, 2023 14:05
@jeroenmol-form3 jeroenmol-form3 merged commit 26eef6d into master Dec 13, 2023
12 checks passed
@jeroenmol-form3 jeroenmol-form3 deleted the jmol-fix-dashboard-collector branch December 13, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants