Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cloudstack host-stop recover to work when all hosts are up #87

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sshutovskyi-f3
Copy link

@sshutovskyi-f3 sshutovskyi-f3 commented Jul 30, 2024

What problem does this PR solve?

Chaos unable to recover, stuck in infinite loop.

What's changed and how it works?

Previously, when no hosts were found that are shut down, the recovery phase would fail.
Now, in this case the recovery phase would be considered successful.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@sshutovskyi-f3 sshutovskyi-f3 requested a review from a team as a code owner July 30, 2024 14:31
Copy link

Created new release based on commit 9aa6e78

Release tag: v2.6.1-f3-9aa6e-sergii-fix-cloudstack-host-restoring

Link to release

@sshutovskyi-f3 sshutovskyi-f3 merged commit c779ddb into master Jul 30, 2024
46 checks passed
@sshutovskyi-f3 sshutovskyi-f3 deleted the sergii-fix-cloudstack-host-restoring branch July 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants