Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split recovery into phases to use parallel steps better #90

Merged
merged 23 commits into from
Sep 17, 2024

Conversation

sshutovskyi-f3
Copy link

@sshutovskyi-f3 sshutovskyi-f3 commented Sep 5, 2024

What problem does this PR solve?

  1. I would like to run DR test for blue and green clusters at the same time, for that I need to make sure that recovery only affects the correct cluster
  2. Sometimes after the host recovers, the VM is not immediately shown as stopped, so it's not started automatically and k8s node never reaches Ready state, for that VM start - Node uncordon cycle should be retried until all nodes are ready and uncordoned
  3. Hosts in inactive clusters are unnecessarily stopped and recovered

What's changed and how it works?

  • Only VMs and Nodes from the started host should be checked and recovered
  • VM and nodes recovery should be retried multiple times
  • Only hosts hosting schedulable k8s nodes are used for chaos

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@sshutovskyi-f3 sshutovskyi-f3 force-pushed the sergii-add-more-retries-to-hv-recovery branch from a7f3cae to 82468e7 Compare September 5, 2024 13:10
Copy link

github-actions bot commented Sep 5, 2024

Created new release based on commit 80367d3

Release tag: v2.6.1-f3-80367-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

github-actions bot commented Sep 5, 2024

Created new release based on commit 130c31c

Release tag: v2.6.1-f3-130c3-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

github-actions bot commented Sep 5, 2024

Created new release based on commit b5e7358

Release tag: v2.6.1-f3-b5e73-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

github-actions bot commented Sep 5, 2024

Created new release based on commit 342712c

Release tag: v2.6.1-f3-34271-sergii-add-more-retries-to-hv-recovery

Link to release

@sshutovskyi-f3 sshutovskyi-f3 changed the title Add retries to hv recovery, add keyword for vm and nodes filtering Split recovery into phases to use parallel steps better Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Created new release based on commit 47223fd

Release tag: v2.6.1-f3-47223-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

github-actions bot commented Sep 9, 2024

Created new release based on commit 799001d

Release tag: v2.6.1-f3-79900-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

github-actions bot commented Sep 9, 2024

Created new release based on commit 36ee8e4

Release tag: v2.6.1-f3-36ee8-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit ee572ea

Release tag: v2.6.1-f3-ee572-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 22005fc

Release tag: v2.6.1-f3-22005-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 8d60753

Release tag: v2.6.1-f3-8d607-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 986dcf8

Release tag: v2.6.1-f3-986dc-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 31948a7

Release tag: v2.6.1-f3-31948-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 1d67718

Release tag: v2.6.1-f3-1d677-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 13b84d7

Release tag: v2.6.1-f3-13b84-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit 50866bf

Release tag: v2.6.1-f3-50866-sergii-add-more-retries-to-hv-recovery

Link to release

Copy link

Created new release based on commit ef32cdc

Release tag: v2.6.1-f3-ef32c-sergii-add-more-retries-to-hv-recovery

Link to release

@sshutovskyi-f3 sshutovskyi-f3 marked this pull request as ready for review September 17, 2024 07:49
@sshutovskyi-f3 sshutovskyi-f3 requested a review from a team as a code owner September 17, 2024 07:49
@sshutovskyi-f3 sshutovskyi-f3 merged commit 29046a4 into master Sep 17, 2024
46 checks passed
@sshutovskyi-f3 sshutovskyi-f3 deleted the sergii-add-more-retries-to-hv-recovery branch September 17, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant