Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a common check to use as a required check #95

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mikolaj-krzyzanowski-f3
Copy link

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 commented Oct 9, 2024

What problem does this PR solve?

  • Currently, with a large matrix job and several optional tests there are not good required checks for PRs as they can often be skipped.
  • This PR allows setting a single required check that alongside a few other required checks ensures the tests either run when needed or are skipped when not and the PRs are correctly blocked in both cases if there is an issue with the checks.

What's changed and how it works?

  • The single job will verify that required jobs have succeeded and the optional ones either succeeded or were skipped, which happens when their conditions are not fulfilled and is expected for some PRs.
  • Adding a few other jobs to required checks means there shouldn't be a scenario where jobs that are supposed to run were skipped or failed and the PR is mergeable.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 requested a review from a team as a code owner October 9, 2024 07:37
Copy link

github-actions bot commented Oct 9, 2024

Created new release based on commit 0af1314

Release tag: v2.6.1-f3-0af13-quinnh-add-common-check

Link to release

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 merged commit f2289bf into master Oct 9, 2024
26 checks passed
@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 deleted the quinnh-add-common-check branch October 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants