Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tags to help debugging #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

miketonks-form3
Copy link

When rebooting VMS during AZ Loss experiment, it is difficult to correlate logs with actual instances.

InstanceIDs are not long lived, so can change after a rollout making it difficult to verify what happened.

Since there is no obvious name or description field in the instance, I'm adding Tags field which usually contains a name and other useful metadata.

What problem does this PR solve?

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@miketonks-form3 miketonks-form3 requested a review from a team as a code owner December 3, 2024 09:53
Copy link

github-actions bot commented Dec 3, 2024

Created new release based on commit 7b0937e

Release tag: v2.6.1-f3-7b093-mike-aws-tags

Link to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant