chore: Add support for extra in validating webhook #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We experienced problems in our GKE and AKS stacks, where user authentication does not work correctly creating chaos-mesh CRDs.
We received errors such as:
Error from server (Forbidden): error when creating "/experiment.yaml": admission webhook "vauth.kb.io" denied the request: [email protected] is forbidden on namespace test
On investigation, we identified that the validating webooks are at fault, since they do not pass all user information:
username
andgroups
are passed, but notextra
field which contains cloud provider specific auth tokens.What's changed and how it works?
This PR adds
extra
field to the request. Tested in the development stacks and worked as expected.Test can be reproduced by creating a SAR with the following bash command:
"status":{"allowed":true,"reason":"access granted by IAM permissions."
Related changes
UI interface
Cherry-pick to release branches (optional)
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: