Merge pull request #25 from form3tech-oss/fix/secure-param

fix: secure param

.github/workflows/test.yml

@@ -27,7 +27,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        tf_version: ["1.0", "1.1", "1.2", "1.3", "1.4", "1.5"]
+        tf_version: ["1.4", "1.5", "1.6", "1.7"]
+      fail-fast: false
     needs: setup-drp
     steps:
       - name: Checkout
@@ -57,5 +58,6 @@ jobs:
           TF_ACC_LOG: trace
           LOG_LEVEL: debug
           RS_KEY: rocketskates:r0cketsk8ts
+          RS_DISABLE_DNS: true
         run: |
           go test -v ./drpv4 -cover -timeout 30m -count 1

drpv4/resource_drp_profile_param.go

@@ -151,17 +151,21 @@ func resourceProfileParamCreate(d *schema.ResourceData, m interface{}) error {
 	req := c.session.Req().UrlFor("profiles", profile, "params", name)
 
 	if secureValue != "" {
-		sv := models.SecureData{}
+		sv := &models.SecureData{}
 		pubkey, err := getPublickey(c, profile)
 		if err != nil {
 			return err
 		}
 
-		err = sv.Marshal(pubkey, value)
+		err = sv.Marshal(pubkey, secureValue)
 		if err != nil {
 			return err
 		}
 
+		if err := sv.Validate(); err != nil {
+			return err
+		}
+
 		if err := req.Post(sv).Do(nil); err != nil {
 			return err
 		}
@@ -206,6 +210,15 @@ func resourceProfileParamRead(d *schema.ResourceData, m interface{}) error {
 		}
 
 		d.Set("value", value)
+		d.Set("secure_value", nil)
+	} else {
+		d.Set("value", nil)
+
+		var securedValue string
+		if err := c.session.Req().UrlFor("profiles", profile, "params", name).Params("decode", "true").Do(&securedValue); err != nil {
+			return err
+		}
+		d.Set("secure_value", securedValue)
 	}
 
 	return nil

drpv4/resource_drp_reservation.go

@@ -70,6 +70,7 @@ func resourceReservation() *schema.Resource {
 				Type:        schema.TypeBool,
 				Description: "Reservation scoped",
 				Optional:    true,
+				ForceNew:    true,
 			},
 			"strategy": {
 				Type:        schema.TypeString,