ci: add benchmarks #505
Merged
ci: add benchmarks #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new 'Benchmark' job in the GitHub Actions workflow to run performance tests and generate graphs. Save the test report as an artifact in the Earthfile. The job runs on 'github-001' and triggers on PRs labeled 'benchmarks' or on the main branch.
Remove the line saving the test report artifact locally, as it is unnecessary for the current performance testing setup.
Create a new benchmark.yml for the benchmark job. Remove the benchmark job from main.yml. This organizes workflows better by separating concerns.
Add a new 'ci' target in Earthfile for local performance testing. Update the benchmark workflow to use the new 'ci' step and upgrade actions/upload-artifact to v4.
Add sudo to the systemctl restart command to ensure proper permissions are granted when restarting the ledger service during performance tests.
…hmark workflow Remove redundant ci block from Earthfile and update the GitHub Actions benchmark workflow to execute the 'run' target with appropriate arguments.
…hmark workflow Remove redundant ci block from Earthfile and update the GitHub Actions benchmark workflow to execute the 'run' target with appropriate arguments.
Update the command to start `ledger serve` without using `systemctl`. Add a command to kill the server process after benchmarking.
flemzord
force-pushed
the
ci-add-benchmarks
branch
from
4145b87 to
493644c
Compare
gfyrag
pushed a commit
that referenced
this pull request
Oct 16, 2024
* feat(performance): add benchmark step to CI workflow Add a new 'Benchmark' job in the GitHub Actions workflow to run performance tests and generate graphs. Save the test report as an artifact in the Earthfile. The job runs on 'github-001' and triggers on PRs labeled 'benchmarks' or on the main branch. * remove unnecessary dependency from Benchmark job in GitHub Actions * perf(performance): remove artifact saving from Earthfile Remove the line saving the test report artifact locally, as it is unnecessary for the current performance testing setup. * refactor(workflows): move benchmark job to a separate workflow Create a new benchmark.yml for the benchmark job. Remove the benchmark job from main.yml. This organizes workflows better by separating concerns. * feat: add CI step for performance testing and update benchmark workflow Add a new 'ci' target in Earthfile for local performance testing. Update the benchmark workflow to use the new 'ci' step and upgrade actions/upload-artifact to v4. * fix(performance): add sudo to systemctl restart in Earthfile Add sudo to the systemctl restart command to ensure proper permissions are granted when restarting the ledger service during performance tests. * refactor(performance): remove ci block from Earthfile and update benchmark workflow Remove redundant ci block from Earthfile and update the GitHub Actions benchmark workflow to execute the 'run' target with appropriate arguments. * refactor(performance): remove ci block from Earthfile and update benchmark workflow Remove redundant ci block from Earthfile and update the GitHub Actions benchmark workflow to execute the 'run' target with appropriate arguments. * fix(workflow): remove sudo from systemctl command in benchmark.yml * fix(workflow): remove sudo from systemctl command in benchmark.yml * fix(workflow): update benchmark server start and stop commands Update the command to start `ledger serve` without using `systemctl`. Add a command to kill the server process after benchmarking.
gfyrag
pushed a commit
that referenced
this pull request
Oct 23, 2024
* feat(performance): add benchmark step to CI workflow Add a new 'Benchmark' job in the GitHub Actions workflow to run performance tests and generate graphs. Save the test report as an artifact in the Earthfile. The job runs on 'github-001' and triggers on PRs labeled 'benchmarks' or on the main branch. * remove unnecessary dependency from Benchmark job in GitHub Actions * perf(performance): remove artifact saving from Earthfile Remove the line saving the test report artifact locally, as it is unnecessary for the current performance testing setup. * refactor(workflows): move benchmark job to a separate workflow Create a new benchmark.yml for the benchmark job. Remove the benchmark job from main.yml. This organizes workflows better by separating concerns. * feat: add CI step for performance testing and update benchmark workflow Add a new 'ci' target in Earthfile for local performance testing. Update the benchmark workflow to use the new 'ci' step and upgrade actions/upload-artifact to v4. * fix(performance): add sudo to systemctl restart in Earthfile Add sudo to the systemctl restart command to ensure proper permissions are granted when restarting the ledger service during performance tests. * refactor(performance): remove ci block from Earthfile and update benchmark workflow Remove redundant ci block from Earthfile and update the GitHub Actions benchmark workflow to execute the 'run' target with appropriate arguments. * refactor(performance): remove ci block from Earthfile and update benchmark workflow Remove redundant ci block from Earthfile and update the GitHub Actions benchmark workflow to execute the 'run' target with appropriate arguments. * fix(workflow): remove sudo from systemctl command in benchmark.yml * fix(workflow): remove sudo from systemctl command in benchmark.yml * fix(workflow): update benchmark server start and stop commands Update the command to start `ledger serve` without using `systemctl`. Add a command to kill the server process after benchmarking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.