Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payments): handle precision from string #1275

Merged
merged 6 commits into from
Feb 27, 2024
Merged

feat(payments): handle precision from string #1275

merged 6 commits into from
Feb 27, 2024

Conversation

paul-nicolas
Copy link
Contributor

@paul-nicolas paul-nicolas commented Feb 23, 2024 •
edited
Loading

Fixes ENG-707

@paul-nicolas paul-nicolas marked this pull request as ready for review February 26, 2024 13:40
@paul-nicolas paul-nicolas requested a review from a team as a code owner February 26, 2024 13:40
gfyrag
gfyrag approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems complicated but if it works

@paul-nicolas paul-nicolas added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 925e9ce Feb 27, 2024
11 checks passed
@paul-nicolas paul-nicolas deleted the feat/currency-amount branch February 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyrag gfyrag gfyrag approved these changes

@altitude altitude Awaiting requested review from altitude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-nicolas @gfyrag