FIO-9649: update componentMatches fn to not omit layout components; add tests #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9649
Description
This issue surfaced with a regression in the
resourcefields
component shim used by the Save Submission action.Previously, I could call
getComponent('keyToLayoutComponent'
from a nested component instance (e.g. in the Developer Portal application's resourcefields component shim, which calls that function to get a Panel component). However, with the introduction of the new pathing regime, this broke because we omit layout components by checking the component JSON for theinput
property.This PR updates that change to allow for layout components to be retrieved using
getComponent
using just their key.Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Automated test added
Checklist: