Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoinMarket: Add support for jmwalletd #699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seberm
Copy link
Contributor

@seberm seberm commented May 14, 2024

@seberm seberm force-pushed the feature/add-jmwalletd branch 14 times, most recently from 27ff5b4 to 9cea6a5 Compare May 18, 2024 20:04
@seberm seberm mentioned this pull request May 18, 2024
5 tasks
@seberm seberm force-pushed the feature/add-jmwalletd branch 15 times, most recently from 47b5009 to 9457a4d Compare May 23, 2024 21:25
@seberm seberm force-pushed the feature/add-jmwalletd branch 12 times, most recently from eb6763e to de77a06 Compare May 25, 2024 11:37
@seberm
Copy link
Contributor Author

seberm commented May 25, 2024

Hello @erikarvstedt @jonasnick ,
I am finallizing the patches for jmwalletd support, which is a prerequisite for the Jam (see PR #700).

This service should probably only be accessible locally. I don't see any reason to expose it via an onion address.

Additionally, please take a look at the address option, which I have marked as readOnly and internal. The reason for this is that I haven't found a way to set the listening address for jmwalletd. The service always listens on 0.0.0.0.

Also, do you think it makes sense to add some documentation about this service to the README?

Could you please review this and assist with the service hardening?

Thank you!

@seberm seberm marked this pull request as ready for review May 25, 2024 11:38
@seberm seberm force-pushed the feature/add-jmwalletd branch 3 times, most recently from 7135884 to b6454fd Compare May 27, 2024 19:47
@seberm seberm marked this pull request as draft May 27, 2024 19:54
@seberm seberm force-pushed the feature/add-jmwalletd branch 3 times, most recently from 62a3378 to 4d34ced Compare May 27, 2024 20:02
@seberm seberm marked this pull request as ready for review May 27, 2024 20:11
@naturallaw777
Copy link

Just wanted to checking in. What are the next steps or further organization to get this merged?

@naturallaw777
Copy link

Thanks @seberm for putting this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants