Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NixOS 24.11 #750

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Update to NixOS 24.11 #750

merged 12 commits into from
Dec 17, 2024

Conversation

erikarvstedt
Copy link
Collaborator

@erikarvstedt erikarvstedt commented Dec 12, 2024

Todo:

  • Deploy to nixbitcoin.org

@erikarvstedt
Copy link
Collaborator Author

erikarvstedt commented Dec 13, 2024

This branch runs fine on nixbitcoin.org. Ready to merge.

Liquid is currently not working in btcpayserver (i.e. in our donation page). This will be fixed by a nbxplorer version update in nixpkgs that I'm preparing right now. Edit: Here's the update: NixOS/nixpkgs#365031.

After merging this, we should also wait for the next nixpkgs-unstable update to be merged before creating the next nix-bitcoin release.

@erikarvstedt erikarvstedt marked this pull request as ready for review December 13, 2024 21:32
@erikarvstedt erikarvstedt marked this pull request as draft December 13, 2024 22:01
Nix 2.24 is the default in NixOS 24.11.

This is required by the following commit that uses a `flake update`
command syntax only supported by Nix >= 2.19.
@erikarvstedt erikarvstedt marked this pull request as ready for review December 13, 2024 22:23
@prusnak
Copy link
Contributor

prusnak commented Dec 14, 2024

Liquid is currently not working in btcpayserver (i.e. in our donation page). This will be fixed by a nbxplorer version update in nixpkgs that I'm preparing right now. Edit: Here's the update: NixOS/nixpkgs#365031.

Merged NixOS/nixpkgs#365031
Also merged the backport of this PR to nixos-24.11 in NixOS/nixpkgs#365068

@erikarvstedt erikarvstedt force-pushed the nixos-24.11 branch 2 times, most recently from 6fdfab9 to 929e6a4 Compare December 14, 2024 09:46
Python 3.12 is the default in Nixos 24.11.
All tests succeed with Python 3.12.

Context:

Related issue:
JoinMarket-Org/joinmarket-clientserver#1589

This issue contains no hints on what changes caused joinmarket to be
incompatible/compatible with Python 3.12.

The restriction to Python <3.12 was added
here (JoinMarket-Org/joinmarket-clientserver#1587)
in Oct 2023.

This post
(JoinMarket-Org/joinmarket-clientserver#1589 (comment))
in the above issue mentions on 2024-05-19 that tests are running again
with Python 3.12.

The current joinmarket version (0.9.11) was released on 2024-02-22.
Fixes this warning:
Explorer: Options 'automigrate' is obsolete and ignored...
Fixes this warning from the NixOS VM test script linter:
SyntaxWarning: invalid escape sequence '\['
Adds support for NixOS 24.11
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b5e5974

@jonasnick jonasnick merged commit 32b59a6 into fort-nix:master Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants