fix FullSuite

phpunit.xml.dist

@@ -8,7 +8,6 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
 >
     <testsuites>
         <testsuite name="ParaTest Unit Tests">

src/Runners/PHPUnit/Configuration.php

@@ -107,7 +107,7 @@ public function getSuitesName()
         }
         $nodes = $this->xml->xpath('//testsuites/testsuite');
         $names = [];
-        while (list(, $node) = each($nodes)) {
+        foreach ($nodes as $node) {
            $names[] = (string)$node['name'];
         }
         return $names;

src/Runners/PHPUnit/FullSuite.php

@@ -3,50 +3,49 @@
 
 namespace ParaTest\Runners\PHPUnit;
 
-use Symfony\Component\Process\ProcessBuilder;
-
 class FullSuite extends ExecutableTest
 {
     /**
      * @var  string
      */
     protected $suiteName;
 
+    /**
+     * @var string
+     */
+    protected $configPath;
+
     /**
      * @param string $suiteName
      * @param string $configPath
      */
     public function __construct($suiteName, $configPath)
     {
         parent::__construct($suiteName);
+
         $this->suiteName = $suiteName;
         $this->configPath = $configPath;
     }
 
-
-    protected function getCommandString($binary, $options = array())
+    /**
+     * {@inheritdoc}
+     */
+    protected function getCommandString(string $binary, array $options = [])
     {
-        $builder = new ProcessBuilder();
-        $builder->setPrefix($binary);
-        foreach ($options as $key => $value) {
-            $builder->add("--$key");
-            if ($value !== null) {
-                $builder->add($value);
-            }
-        }
-
-        $builder->add('-c');
-        $builder->add($this->configPath);
-
-        $builder->add('--testsuite');
-        $builder->add($this->suiteName);
-
-        $process = $builder->getProcess();
-        return $process->getCommandLine();
+        return parent::getCommandString(
+            $binary,
+            array_merge(
+                $options,
+                [
+                    'configuration' => $this->configPath,
+                    'testsuite' => $this->suiteName,
+                ]
+            )
+        );
     }
 
-    public function getTestCount()
+    public function getTestCount(): int
     {
         return 1; //There is no simple way of knowing this
     }
-}
+}