Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit messages for screenshot workflows #1184

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

AsCress
Copy link
Contributor

@AsCress AsCress commented Feb 4, 2025

Fixes a small issue in the commit messages for the screenshot workflows.

Summary by Sourcery

CI:

  • Standardize the commit messages for screenshot updates.

Copy link
Contributor

sourcery-ai bot commented Feb 4, 2025

Reviewer's Guide by Sourcery

This pull request updates the commit messages for the screenshot workflows in both the Android and iOS actions. The change removes the versionCode from the commit message.

Sequence diagram for screenshot workflow commit process

sequenceDiagram
    participant CI as CI/CD Pipeline
    participant Git as Git Repository

    Note over CI: Screenshot workflow starts
    CI->>Git: Create orphan branch 'temporary'
    CI->>Git: Add all files
    CI->>Git: Create commit with updated message format
    Note right of CI: New format: [Auto] Update screenshots (timestamp)
    CI->>Git: Delete existing fastlane branch
    CI->>Git: Rename temporary to fastlane branch
    CI->>Git: Force push to origin
Loading

Flow diagram for screenshot commit message changes

flowchart LR
    A[Start] --> B[Create temporary branch]
    B --> C[Stage changes]
    C --> D[Commit with new message format]
    D --> E[Replace fastlane branch]
    E --> F[Force push]
    F --> G[End]

    subgraph Old Message Format
    H["[Auto] Update screenshots for versionCode: XXX (timestamp)"]
    end

    subgraph New Message Format
    I["[Auto] Update screenshots (timestamp)"]
    end
Loading

File-Level Changes

Change Details Files
Removed versionCode from the commit message in the screenshot workflows.
  • Removed the versionCode variable from the commit message in the Android screenshot workflow.
  • Removed the versionCode variable from the commit message in the iOS screenshot workflow.
.github/actions/screenshot-android/action.yml
.github/actions/screenshot-ios/action.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AsCress AsCress requested a review from adityastic February 4, 2025 16:39
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Feb 4, 2025

@adityastic adityastic merged commit ae0212b into fossasia:flutter_app Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants