-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: commit messages for screenshot workflows #1184
Conversation
Reviewer's Guide by SourceryThis pull request updates the commit messages for the screenshot workflows in both the Android and iOS actions. The change removes the versionCode from the commit message. Sequence diagram for screenshot workflow commit processsequenceDiagram
participant CI as CI/CD Pipeline
participant Git as Git Repository
Note over CI: Screenshot workflow starts
CI->>Git: Create orphan branch 'temporary'
CI->>Git: Add all files
CI->>Git: Create commit with updated message format
Note right of CI: New format: [Auto] Update screenshots (timestamp)
CI->>Git: Delete existing fastlane branch
CI->>Git: Rename temporary to fastlane branch
CI->>Git: Force push to origin
Flow diagram for screenshot commit message changesflowchart LR
A[Start] --> B[Create temporary branch]
B --> C[Stage changes]
C --> D[Commit with new message format]
D --> E[Replace fastlane branch]
E --> F[Force push]
F --> G[End]
subgraph Old Message Format
H["[Auto] Update screenshots for versionCode: XXX (timestamp)"]
end
subgraph New Message Format
I["[Auto] Update screenshots (timestamp)"]
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/13140367023/artifacts/2535296472 |
Fixes a small issue in the commit messages for the screenshot workflows.
Summary by Sourcery
CI: