-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: orientation-change-Issue-fixes. #1186
Conversation
Reviewer's Guide by SourceryThis pull request addresses an orientation issue on the DrawBadgeScreen by ensuring that the app returns to portrait mode when navigating back, and it also updates macOS plugin registration by adding support for a new plugin and modifying an existing one. Sequence diagram for orientation reset on DrawBadgeScreensequenceDiagram
actor User
participant DrawBadgeScreen
participant SystemChrome
User->>DrawBadgeScreen: Press Back Button
DrawBadgeScreen->>DrawBadgeScreen: onWillPop()
DrawBadgeScreen->>DrawBadgeScreen: _resetPortraitOrientation()
DrawBadgeScreen->>SystemChrome: setPreferredOrientations([portraitUp, portraitDown])
SystemChrome-->>DrawBadgeScreen: Orientation reset complete
DrawBadgeScreen-->>User: Allow back navigation
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dhruv1797 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Review if calling _resetPortraitOrientation in both dispose and onWillPop could lead to redundant calls or unexpected orientation behavior.
- Ensure the updated plugin registration order in GeneratedPluginRegistrant.swift meets the initialization requirements of the new plugins.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@Jhalakupadhyay the common pipeline did not pass |
orientation-change-issue-fixes.mp4
I have fixes the orientation issue fixes, now the app come back to potrait mode again when we pressed back button from the DrawBadgeScreen. pls review it.
Summary by Sourcery
Bug Fixes: