-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added more information for the Google IO event #179
Conversation
@mariobehling @mahikaw @Princu7 |
@arp95 seems good. Please look into the following things:-
|
@mahikaw The featured speakers are selected on the basis of position and i think 150+ are ample enough for an event, you cant expect more! For the keynote instance i know there was some issue. The issue here is its an individual event which doesnt have any track. So I thought putting it in Android one. |
|
@mahikaw thanks for pointing out. Updated. @mariobehling @Princu7 please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arp95 please use the Google I/O logo instead.
@mahikaw doing it. please review a bit earlier from next time onwards. Thanks! |
Hi @arp95! Looks like your PR has some conflicts. 😟 |
1 similar comment
Hi @arp95! Looks like your PR has some conflicts. 😟 |
@arp95 Thanks. Looks Nice. Some of the pictures of speakers are not displaying. Might be because of a typo in the JSON file. Could you please check it? Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice Work :)
@mahikaw Can you please review? Thanks!!
In general looks good to me except for a few things- |
@Princu7 |
The logo looks a little out of place on the front page. On rest of the pages, it looks good. One thing we can do is remove the amount of white background in the image by cropping it. Or slightly darken the color of the background. Both are viable options. But, this issue should not be a blocker I guess. |
fine then. |
Hi @arp95! Looks like your PR has some conflicts. 😟 |
Hi @arp95! Looks like your PR has some conflicts. 😟 |
Hi @arp95! Looks like this PR was closed without merging. |
Adding the information for now. Will remove the [WIP] when complete.
fixes #152