Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added more information for the Google IO event #179

Closed
wants to merge 1 commit into from
Closed

fix: added more information for the Google IO event #179

wants to merge 1 commit into from

Conversation

arp95
Copy link
Contributor

@arp95 arp95 commented Jun 21, 2017

Adding the information for now. Will remove the [WIP] when complete.

fixes #152

@arp95 arp95 changed the title [WIP] fix: added more information for the event fix: added more information for the event Jun 23, 2017
@arp95
Copy link
Contributor Author

arp95 commented Jun 23, 2017

@mahikaw
Copy link
Contributor

mahikaw commented Jun 24, 2017

@arp95 seems good. Please look into the following things:-

  • Mention the event name in the issue and you can edit the issue description now that the PR is complete according to you.

  • How have you selected the featured speakers? Some are missing and some of them seem extra I guess. For instance, the speaker right after Sundar Pichai in the keynote, Scott Huffmann is missing.

  • Why is "Android" the track for keynote?

@arp95 arp95 changed the title fix: added more information for the event fix: added more information for the Google IO event Jun 24, 2017
@arp95
Copy link
Contributor Author

arp95 commented Jun 24, 2017

@mahikaw
the issue still has spark event sample files to be added which i will do in another pr.

The featured speakers are selected on the basis of position and i think 150+ are ample enough for an event, you cant expect more!

For the keynote instance i know there was some issue. The issue here is its an individual event which doesnt have any track. So I thought putting it in Android one.

@mahikaw
Copy link
Contributor

mahikaw commented Jun 24, 2017

@arp95

  • I think you should create separate issues for different events. It'll be more clear then.

  • From what I took away from creating my last F8 sample, the keynote speakers are the most important. My suggestion would be that you go through the keynote video for instance and then find out the keynote speakers. Also, remove the ones that aren't keynote speakers.

  • You should create a new "keynote" track as @mariobehling had once said on gitter.

@arp95
Copy link
Contributor Author

arp95 commented Jun 24, 2017

@mahikaw thanks for pointing out.

Updated.
Link: https://arp95.github.io/GoogleIO_17/

@mariobehling @Princu7 please review.

Copy link
Contributor

@mahikaw mahikaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arp95 please use the Google I/O logo instead.

@arp95
Copy link
Contributor Author

arp95 commented Jun 30, 2017

@mahikaw doing it. please review a bit earlier from next time onwards. Thanks!

@open-event-bot
Copy link

Hi @arp95!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

1 similar comment
@open-event-bot
Copy link

Hi @arp95!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@arp95
Copy link
Contributor Author

arp95 commented Jun 30, 2017

@mahikaw @Princu7
please review.

@Princu7
Copy link
Contributor

Princu7 commented Jun 30, 2017

@arp95 Thanks. Looks Nice. Some of the pictures of speakers are not displaying. Might be because of a typo in the JSON file. Could you please check it? Thanks!!

Copy link
Contributor

@Princu7 Princu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice Work :)
@mahikaw Can you please review? Thanks!!

@mahikaw
Copy link
Contributor

mahikaw commented Jul 1, 2017

In general looks good to me except for a few things-
@arp95 Could you look at the logo once? It has white background. Please use a logo that doesn't have a white background.
Also, all the sponsors have the same "google products" link. Could you add product specific links instead?

@arp95
Copy link
Contributor Author

arp95 commented Jul 1, 2017

@Princu7
can you look into the logo, how can we ensure to look ot good.
regarding sponsers @mariobehling should i remove sponsors as discussed?

@Princu7
Copy link
Contributor

Princu7 commented Jul 1, 2017

The logo looks a little out of place on the front page. On rest of the pages, it looks good. One thing we can do is remove the amount of white background in the image by cropping it. Or slightly darken the color of the background. Both are viable options. But, this issue should not be a blocker I guess.

@arp95
Copy link
Contributor Author

arp95 commented Jul 1, 2017

fine then.
@mariobehling please review and merge.

@open-event-bot
Copy link

open-event-bot bot commented Jul 2, 2017

Hi @arp95!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@open-event-bot
Copy link

open-event-bot bot commented Jul 2, 2017

Hi @arp95!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@arp95 arp95 closed this Jul 2, 2017
@open-event-bot
Copy link

open-event-bot bot commented Jul 2, 2017

Hi @arp95!

Looks like this PR was closed without merging.
Please try not to make test/temporary PRs :) Keeps the repo clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct the sample event files of Google IO event
3 participants