Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added information for google io event #196

Merged
merged 1 commit into from
Aug 24, 2017
Merged

added information for google io event #196

merged 1 commit into from
Aug 24, 2017

Conversation

arp95
Copy link
Contributor

@arp95 arp95 commented Jul 8, 2017

Copy link
Contributor

@Princu7 Princu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor issues. The logo of the event is white and looks a little odd on the front page. Also, the sponsor section consists of just the Google products which is not apt I guess.

[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arp95 What was the source for this data ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan94
i was told by mario in case of mozilla all hands to list all products of mozilla as sponsors. i did the same over here. should i remove this then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arp95 but their links are same?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariobehling I don't think we should assume a list of sponsors when they haven't officially mentioned them. If there are no sponsors listed on the official event website, then we shouldn't be showing anything either.

cc @arp95

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so removing all the sponsors @niranjan94

@open-event-bot
Copy link

open-event-bot bot commented Jul 9, 2017

Hi @arp95!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@arp95
Copy link
Contributor Author

arp95 commented Jul 9, 2017

@niranjan94 @Princu7
please review now.

Link: https://arp95.github.io/GoogleIO_17/

Copy link
Contributor

@Princu7 Princu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the style of the event logo. Umm, I don't know why but I think I liked the previous logo better 😄 The text is little hard to read on this one. Let's see what others think!

Apart from that, good work removing the sponsors. There are some issues with the map section (it is slightly displaced below and text is bold in some areas) but it is from the web app side and work is going on to eliminate them 👍

@arp95
Copy link
Contributor Author

arp95 commented Jul 10, 2017

@niranjan94 please provide your inputs.

Copy link
Contributor

@Princu7 Princu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please try to replicate what was done to remove the white background in the PyCon Sample? I guess the logo would look much better then. Maybe give it a try. Thanks!

@arp95
Copy link
Contributor Author

arp95 commented Jul 10, 2017

sure having a look.

@mariobehling
Copy link
Member

I am merging this as work in progress.

@mariobehling mariobehling merged commit b7052b1 into fossasia:master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants