-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added information for google io event #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few minor issues. The logo of the event is white and looks a little odd on the front page. Also, the sponsor section consists of just the Google products which is not apt I guess.
sample/GoogleIO17/sponsors
Outdated
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arp95 What was the source for this data ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niranjan94
i was told by mario in case of mozilla all hands to list all products of mozilla as sponsors. i did the same over here. should i remove this then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arp95 but their links are same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariobehling I don't think we should assume a list of sponsors when they haven't officially mentioned them. If there are no sponsors listed on the official event website, then we shouldn't be showing anything either.
cc @arp95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so removing all the sponsors @niranjan94
Hi @arp95! Looks like your PR has some conflicts. 😟 |
@niranjan94 @Princu7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the style of the event logo. Umm, I don't know why but I think I liked the previous logo better 😄 The text is little hard to read on this one. Let's see what others think!
Apart from that, good work removing the sponsors. There are some issues with the map section (it is slightly displaced below and text is bold in some areas) but it is from the web app side and work is going on to eliminate them 👍
@niranjan94 please provide your inputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please try to replicate what was done to remove the white background in the PyCon Sample? I guess the logo would look much better then. Maybe give it a try. Thanks!
sure having a look. |
I am merging this as work in progress. |
fixes #179
Link for web app: https://arp95.github.io/GoogleIO_17/
@mahikaw @Princu7 @mariobehling
please review.