Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SparkSummit17 sample #242

Closed
wants to merge 5 commits into from
Closed

Updated SparkSummit17 sample #242

wants to merge 5 commits into from

Conversation

Jigar3
Copy link
Contributor

@Jigar3 Jigar3 commented Dec 16, 2017

#241 Updated the SparkSummit Sample according to the new API

@agbilotia1998
Copy link
Member

@Jigar3 give a deployment link of the sample generated through web app generator.

@Jigar3
Copy link
Contributor Author

Jigar3 commented Dec 17, 2017

Here is the deployment link:
https://jigar3.github.io/SparkSummit17/

@open-event-bot
Copy link

Hi @Jigar3!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@Jigar3
Revert "issue fossasia#243"
22bb5d3 
This reverts commit 404ce17.
@open-event-bot
Copy link

Hi @Jigar3!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@Jigar3 Jigar3 changed the title Updated the files acc. to the new API Updated SparkSummit17 sample Dec 17, 2017
agbilotia1998
agbilotia1998 reviewed Dec 17, 2017
View reviewed changes
sample/SparkSummit17/sponsors

]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a line space here.And similar spaces are required at various places.

@agbilotia1998
Copy link
Member

@Jigar3 also the sample generated is not generated correctly.

@dilpreetsio dilpreetsio mentioned this pull request Jan 7, 2018
Closed
@agbilotia1998
Copy link
Member

@Jigar3 change the state key to accepted instead of draft in sessions json that would generate speakers .Rest I am debugging the remaining fields.

@mariobehling
Copy link
Member

It seems like this PR has not been completed. I am closing this due to inactivity. Please open a new PR taking care of requested changes, if you are still interested to participate. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agbilotia1998 agbilotia1998 agbilotia1998 left review comments

Assignees

@Jigar3 Jigar3

Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jigar3 @agbilotia1998 @mariobehling