Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed if condition for no checkbox selected #3551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arteevraina
Copy link

Closes: #3550
Changes: Removed if condition when no checkbox is selected.
@snitin315 @927tanmay Since, discussed with about Skill being default. Therefore, we don't require this if condition when nothing is checked.
Please Review :)

Copy link
Member

@anishagg17 anishagg17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the desired behaviour. So, we don't need to remove this. @akshatnitd What do you think about it?

@arteevraina
Copy link
Author

It is the desired behaviour. So, we don't need to remove this. @akshatnitd What do you think about it?

@anishagg17 This piece of code is not required. Since we always want Skill selected by default.

Copy link
Member

@thewasif thewasif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there should always be one option that is checked, the issue described is not valid. And you have already been told that.

But we don't want "Skills" checkbox to be checked ALWAYS. So, what are you really trying to do?

@927tanmay
Copy link
Member

Closes: #3550
Changes: Removed if condition when no checkbox is selected.
@snitin315 @927tanmay Since, discussed with about Skill being default. Therefore, we don't require this if condition when nothing is checked.
Please Review :)

We discussed that the issue wasn't a valid one since skill being default is the desired behaviour. So, I don't thing the mentioned line of code should be removed.

@arteevraina
Copy link
Author

Since there should always be one option that is checked, the issue described is not valid. And you have already been told that.

But we don't want "Skills" checkbox to be checked ALWAYS. So, what are you really trying to do?

Since one operation is always checked therefore we are not going into that condition anyways that I have removed.@MuhammadWasif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skilll checkbox getting checked automatically
4 participants