-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed search bar on 404 page #1452
base: development
Are you sure you want to change the base?
Conversation
@Orbiter @mariobehling @simsausaurabh @praveenojha33 Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still this is not ready
please check spec.ts file there is still something to remove
@samagragupta
Also travis is failing because of that
@subhahu123 Done the changes. |
Codecov Report
@@ Coverage Diff @@
## development #1452 +/- ##
===============================================
- Coverage 62.2% 62.16% -0.05%
===============================================
Files 51 51
Lines 1450 1443 -7
Branches 181 180 -1
===============================================
- Hits 902 897 -5
+ Misses 438 436 -2
Partials 110 110
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove autocomplete service also
@subhahu123 Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samagragupta I am unable to open test link for your PR.
Also I do not think leaving a lot of empty space on 404 will be good idea. It will be great if few other people @AakashMallik @shreyanshdwivedi can suggest their views on it. If you can provide a heroku link please provide that.
@praveenojha33 The link is working for me. |
@samagragupta Please add a heroku link I am unable to navigate to 404 page. |
@samagragupta Please provide heroku link I am unable to see changes on 404 page using surge link. The image is appearing odd to me as we do not have anything in lower half of the screen. If possible make it similar to google. Something like this http://google.co.in/dnsacxklsq. You can crop the current image and put it in middle. |
This is what I have made changes. |
@mariobehling Please review. |
@samagragupta Could you please deploy it on heroku and provide link to review? |
@praveenojha33 Are we good to go? |
Fixes #1430
Checklist
master
branch.Changes proposed in this pull request:
-Removed search bar on 404 page
-Removed all details from .html, .css, .ts, .spec.ts