Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message linting #12

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

patrickocoffeyo
Copy link
Contributor

@patrickocoffeyo patrickocoffeyo commented Feb 22, 2018

This PR introduces commit message linting. The mechanisms introduced in this PR will scan and validate commit messages.

Steps to demo

  • Make a small change to a file
  • Run git add -A ; git commit -m "asdfasdfasdf dumb commit"
  • Note that your commit is rejected.

@evanmwillhite
Copy link
Contributor

This is really neat! Once we figure out #11, I can get it merged in here, resolve the conflict and get this in too.

@evanmwillhite
Copy link
Contributor

Pulled in recent from #11, fixed merge conflicts and made some linting tweaks. Want to give it a once-over @patrickocoffeyo?

@evanmwillhite evanmwillhite changed the base branch from master to develop April 10, 2018 22:27
Copy link
Contributor

@ModulesUnraveled ModulesUnraveled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants