-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the longstanding bug on PRs: "We do not build CI environments." #68
base: main
Are you sure you want to change the base?
Conversation
We already show an error message and can continue the build
Due to not being specific enough with filters. GitHub would happily ignore a filter that wasn't specific enough.
I don't see that this hurts anything, other than slightly slowing down branch build rejections, so I would lean towards committing it if it is useful to someone, but the linked issues are all many years old, and I've never run into this issue ever, as many projects I've set up in circle and pull requests I've made, so my gut says it's an outdated and unneeded fix. Do you have any examples of when this has occurred? I recall seeing in slack a while back that you ran into this issue repeatedly on a specific project. Maybe there is a project setup difference between how you and I set up circle projects that we could identify, document and learn from. |
On 4K GitHub/CircleCI I run into this bug rarely these days. We just moved NYU Stern Public to a client-owned repo, using the free tier of CircleCI. There we were running into this bug on 95% of builds. I just invited you there. On any build for
So I suspect it's one of two things:
|
I just ran into this on Stateweb: Here rerunning the build fixed the problem: |
Fixes #67