Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the longstanding bug on PRs: "We do not build CI environments." #68

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dalin-
Copy link
Contributor

@dalin- dalin- commented Jan 22, 2025

Fixes #67

@dalin- dalin- requested a review from mdlutz24 January 22, 2025 16:21
@dalin- dalin- added bug Something isn't working Ready to review High Priority labels Jan 22, 2025
We already show an error message and can continue the build
Due to not being specific enough with filters.  GitHub would happily ignore a filter that wasn't specific enough.
@mdlutz24
Copy link
Member

mdlutz24 commented Feb 6, 2025

I don't see that this hurts anything, other than slightly slowing down branch build rejections, so I would lean towards committing it if it is useful to someone, but the linked issues are all many years old, and I've never run into this issue ever, as many projects I've set up in circle and pull requests I've made, so my gut says it's an outdated and unneeded fix. Do you have any examples of when this has occurred? I recall seeing in slack a while back that you ran into this issue repeatedly on a specific project. Maybe there is a project setup difference between how you and I set up circle projects that we could identify, document and learn from.

@mdlutz24 mdlutz24 added question Further information is requested and removed High Priority labels Feb 6, 2025
@dalin-
Copy link
Contributor Author

dalin- commented Feb 6, 2025

On 4K GitHub/CircleCI I run into this bug rarely these days. We just moved NYU Stern Public to a client-owned repo, using the free tier of CircleCI. There we were running into this bug on 95% of builds. I just invited you there.

On any build for setup-environment-vars you'll see

Double checking for PR on NYUSTERN-1161-spacing-pt-7 to work around Circle platform bug.
contacted GitHub
Found PR 8

So I suspect it's one of two things:

  • On the free tier, we're more likely to run into some race condition.
  • I see on many 4K projects Bender has full admin access. Here I've only given him Read access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested Ready to review
Projects
None yet
2 participants