[pull] develop from frappe:develop #536
Open
+7,924
−12,129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Reported-by: Sadik Shaikh <[email protected]> Signed-off-by: Akhil Narang <[email protected]>
* fix: serial numbers not aligned with other cells * refactor: remove top margin from editor
feat: Allow for configurable persistant cron jobs without hooks.py
This adds request timeouts for gthread workers. `gunicorn` repo isn't that active and this issue has been brought up multiple times so I don't think it's gonna get fixed upstream. This is our last resort.
build: switch to gunicorn fork
specify format for parsing datetime
refactor: make scheduled_against mandatory
This test is only passing because ci is sourcing env, it won't work IRL like this.
fix: move ifnull logic to applicaiton for better orm support
perf: use client cache for metadata version
Right now assets.json is read on every requests because of this bug.
Similar to redis, for ergonomics
Single shared key, worth the costs.
perf: use client cache for assets.json
No need to query 1 key at a time.
fix(minor): Extract images from markdown as well
All of following should have <2% utilization when idle: - Redis invalidator thread - Gunicorn workers and master - RQ worker and horses
We serve millions of requests for reading a document, it doesn't make sense to check error and webhooks on all of them. Not all documents even have this configured. If you need it, add it using "connections dashboard" or some custom code.
fix(ux): remove Link clearing
perf: speedup docinfo - skip tags when not used
Otherwise changes to the table can trigger this and allow uploading Signed-off-by: Akhil Narang <[email protected]>
It's disabled by default 🤷
fix: move child table checks to within `set_input()`
* chore: trigger release PRs early Too many CI jobs start at 3 PM blocking everything else, so making this one run 30 min before. * Update initiate_release.yml
* fix: return False if attached doctype is not found * fix(UX): add a open url button in file form * fix(typo): add translate to string * fix: check if it is absolute url * fix: return false via module not found error
(Don't try to insert empty string) Breaks on some v15 sites Signed-off-by: Akhil Narang <[email protected]>
fix: only add expression if truthy
fix(styles): Style cleanups for sidebar, breadcrumb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )