Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow replying on closed tickets #1642

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

shadrak98
Copy link
Collaborator

@shadrak98 shadrak98 commented Dec 6, 2023

Problem:

Customers/ Users were able to reply and thus re-open the tickets which were closed.

Fix:

Users won't be able to reply on the ticket if its marked as closed.

Screenshot:

On Resolved Status
image

On Closed Status
image

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (2d07252) 2.51% compared to head (c12402f) 2.56%.
Report is 22 commits behind head on main.

Files Patch % Lines
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 0.00% 21 Missing ⚠️
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% 10 Missing ⚠️
...vice_level_agreement/hd_service_level_agreement.py 0.00% 3 Missing ⚠️
helpdesk/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1642      +/-   ##
========================================
+ Coverage   2.51%   2.56%   +0.04%     
========================================
  Files         59      59              
  Lines       1908    1912       +4     
========================================
+ Hits          48      49       +1     
- Misses      1860    1863       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadrak98 shadrak98 changed the title fix: don't allow replying on resolved or closed tickets fix: don't allow replying on closed tickets Dec 6, 2023
@nextchamp-saqib nextchamp-saqib merged commit d0ba8b4 into frappe:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants