Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: kpiId type changed from enum to string #49

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

janniclas
Copy link
Contributor

@janniclas janniclas commented Dec 10, 2024

To verify the correctness of the changes I ran the local tests in SPHA.
Further, I integrated the changed version with both, the data-provider, and SPHA-CLI and made the necessary changes to support the type change. See fraunhofer-iem/spha-cli#23 for how this change affects client code.

@janniclas janniclas self-assigned this Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
JUnit Test Report78 ran78 passed0 skipped0 failed

Copy link

github-actions bot commented Dec 10, 2024

Code Coverage

Overall Project 79.38% -1.03% 🍏
Files changed 65.52%

Module Coverage
core 83.36% 🍏
adapter 76.16% -1.86%
Files
Module File Coverage
core KpiHierarchyNode.kt 99.71% 🍏
adapter CveAdapter.kt 100% 🍏
TlcAdapter.kt 89.55% 🍏
TrufflehogAdapter.kt 88.89% 🍏
VcsAdapter.kt 0% -12.12%
OccmdAdapter.kt 0% -33.68%

@janniclas janniclas requested a review from jusito December 10, 2024 13:29
Copy link
Collaborator

@jusito jusito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
mostly renaming beside KpiHierarchyNode, different hierarchies are tested so no additional test required, tests are fine so am I.

@janniclas janniclas merged commit 42734d5 into main Dec 10, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants