enable token based auth #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the x-lhan's work distilled and applied to current master. C.f. fraunhoferfokus@bc790f8
|
Hi Alex! Thanks for the PR. The old PR had too many issues to be merged and is more or less deserted by now. However, @jgimenez opened a PR last week (see #33) which addresses exactly this issue. He wanted to open a new, fine grained PR, but I am not aware of its current state. Let me ping him and if he's out, we'll merge this one. |
|
If this works, I'm happy to use this :) Quickly reviewing this code, it looks cleaner than mine |
yan-foto
requested changes
Apr 4, 2020
| "golang.org/x/crypto/ssh/terminal" | ||
|
|
||
| log "github.com/sirupsen/logrus" | ||
| "github.com/docker/distribution/context" | ||
| schema2 "github.com/docker/distribution/manifest/schema2" | ||
| "github.com/docker/distribution/reference" | ||
| "github.com/docker/distribution/registry/client" | ||
| "github.com/fraunhoferfokus/deckschrubber/util" |
There was a problem hiding this comment.
If you remove this dependency, you also need to remove the file, as it is not used anywhere else.
| "golang.org/x/crypto/ssh/terminal" | ||
|
|
||
| log "github.com/sirupsen/logrus" | ||
| "github.com/docker/distribution/context" | ||
| schema2 "github.com/docker/distribution/manifest/schema2" | ||
| "github.com/docker/distribution/reference" | ||
| "github.com/docker/distribution/registry/client" | ||
| "github.com/fraunhoferfokus/deckschrubber/util" | ||
| "github.com/heroku/docker-registry-client/registry" |
| if *insecure { | ||
| transport = &http.Transport{ | ||
| TLSClientConfig: &tls.Config{ | ||
| InsecureSkipVerify: true, |
There was a problem hiding this comment.
This value should not be hard coded. Again, see how it is solved in #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi yan-foto,
I need to be able to do token based authentication. A while ago x-lhan
made a PR that contained (among other things) necessary changes for
this work. This is the x-lhan's work distilled and applied to current master.
Do you think it would be possible to merge this into your main branch?
C.f. bc790f8
Cheers
Alex