Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ueransim build on arm #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ueransim build on arm #147

wants to merge 1 commit into from

Conversation

xandlom
Copy link

@xandlom xandlom commented Jan 4, 2025

No description provided.

@abousselmi
Copy link
Collaborator

Thanks for your PR.

I would prefer the use of a default environment variable that we can update on build time, rather than "uname" to get the system architecture.

This will result in a predictable builds, especially in automated CI builds.

Cheers,

@xandlom
Copy link
Author

xandlom commented Jan 5, 2025

Hi @abousselmi ,

Thanks for your comment!
Do you mean to use Docker env var TARGETPLATFORM or TARGETARC(https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope)?

BR,
Andrei

@abousselmi
Copy link
Collaborator

Hi @xandlom

TARGETARCH might work ! The only problem is that it's supported by BuildKit, not sure if other build engines like Kaniko support it..

I think you can simply specify something like TARGET_ARCH and set it to x86_64. Then it can be updated using --build-arg.

Cheers,

@abousselmi abousselmi added the enhancement New feature or request label Jan 5, 2025
@abousselmi abousselmi self-requested a review January 5, 2025 12:49
Copy link
Collaborator

@abousselmi abousselmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained previously, we can add

ARG TARGET_ARCH=x86_64

and replace

https://github.com/Kitware/CMake/releases/download/v3.22.1/cmake-3.22.1-linux-`uname -m`.sh -O cmake_installer.sh

by

https://github.com/Kitware/CMake/releases/download/v3.22.1/cmake-3.22.1-linux-${TARGET_ARCH}.sh -O cmake_installer.sh

which can be updated later on using --build-arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants