Merge pull request #145 from Alonza0314/fix/redundent-qos-rule-from-pcf

free5gc · Jan 22, 2025 · d049a7a · d049a7a
2 parents 30c2893 + 9e42e21
commit d049a7a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/internal/context/sm_context.go b/internal/context/sm_context.go
@@ -661,8 +661,10 @@ func (c *SMContext) CreatePccRuleDataPath(pccRule *PCCRule,
 		pccRule.Datapath.AddChargingRules(c, chgLevel, chgData)
 	}
 
-	pccRule.Datapath.AddQoS(c, pccRule.QFI, qosData)
-	c.AddQosFlow(pccRule.QFI, qosData)
+	if pccRule.RefQosDataID() != "" {
+		pccRule.Datapath.AddQoS(c, pccRule.QFI, qosData)
+		c.AddQosFlow(pccRule.QFI, qosData)
+	}
 	return nil
 }
 

diff --git a/internal/context/sm_context_policy.go b/internal/context/sm_context_policy.go
@@ -163,7 +163,11 @@ func (c *SMContext) ApplyPccRules(
 
 			tgtQosID := tgtPcc.RefQosDataID()
 			_, tgtQosData := c.getSrcTgtQosData(decision.QosDecs, tgtQosID)
-			tgtPcc.SetQFI(c.AssignQFI(tgtQosID))
+
+			// only assign the QFI when there is tgtQoSID (i.e. there is QoSData)
+			if tgtQosID != "" {
+				tgtPcc.SetQFI(c.AssignQFI(tgtQosID))
+			}
 
 			// Create Data path for targetPccRule
 			if err := c.CreatePccRuleDataPath(tgtPcc, tgtTcData, tgtQosData, tgtChgData); err != nil {
@@ -180,11 +184,12 @@ func (c *SMContext) ApplyPccRules(
 			if err := applyFlowInfoOrPFD(tgtPcc); err != nil {
 				return err
 			}
-			finalPccRules[id] = tgtPcc
+
 			if tgtTcID != "" {
 				finalTcDatas[tgtTcID] = tgtTcData
 			}
 			if tgtQosID != "" {
+				finalPccRules[id] = tgtPcc
 				finalQosDatas[tgtQosID] = tgtQosData
 			}
 			if tgtChgID != "" {