Merge splash screen animation and progress bar patches onto Capacitor 5 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[email protected] @capacitor/splash [email protected] fork
|
We've already released capacitor 5 with this version of the plugin, merging it as-is. |
benjmo
added a commit
to benjmo/freelancer-capacitor-plugins
that referenced
this pull request
Oct 11, 2024
… 5 (freelancer#10) * Migrate animated splashscreen to splashscreen 2.4.0 * Bump package.json to 4.2.0-fork.0 * bump forked version in package.json to 5.0.8 * Include README changes after build --------- Co-authored-by: fteng <[email protected]> Co-authored-by: Fei Teng <[email protected]> Co-authored-by: Benjamin Mo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title + bump version in package.json
Previously tested with a manual merge effectively of
5.xinto freelancer forked3.xand animation + progress bar worked on Android 11 and iOS.With this specific PR I tested that the animation works but due to what seems like unrelated factors I am unable to load the website (so cannot test the progress bar)