Make ProcessingQueue document_number a CharField to match RECAPDocument #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttys0dev
force-pushed
the
document-number-char
branch
6 times, most recently
from
270c241 to
2a5f89f
Compare
ttys0dev
force-pushed
the
document-number-char
branch
2 times, most recently
from
8d77b5a to
b7bc3c0
Compare
ttys0dev
force-pushed
the
document-number-char
branch
from
b7bc3c0 to
72f6952
Compare
ttys0dev
force-pushed
the
document-number-char
branch
from
72f6952 to
efdea04
Compare
Leading zeros are significant so we shouldn't use BigIntegerField.
ttys0dev
force-pushed
the
document-number-char
branch
from
efdea04 to
9798495
Compare
|
I've added this to our deploy backlog. I'm working on hiring an engineer to take this on, because, well, evidence suggests that I'm failing to do so myself. Growing pains, sorry. |
|
Eduardo, I'm putting this on your backlog somewhere. When it gets to the top, can you give this one more look and, assuming you approve, tune it up for Ramiro to deploy? |
|
@mlissner Sure! |
|
Let's review this one, finally, and see if it still needs to be merged. If so, Alberto, if you can review and if Diego can deploy, that'd be great. Diego, let's talk before you deploy because model changes like this one take special care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leading zeros are significant so we shouldn't use BigIntegerField.
Should help with #2877.