-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4845 pray-and-pray revisions pt. 5 #5109
base: main
Are you sure you want to change the base?
Conversation
…ne/courtlistener into 4845-pray-and-pay-revisions
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend implementing tabbed navigation, mirroring the profile page structure, to better organize the prayer lists. Consequently, we would need to develop two separate views:
prayers/{username}/ -> pending prayers list
prayers/{username}/granted -> granted prayer list
This separation offers several advantages, most notably addressing the current pagination problem. The existing pagination template relies on a single 'page' query parameter, which fails when attempting to paginate two tables on the same page. Implementing tabs allows us to use accurate and independent pagination for both 'Pending' and 'Granted' prayer lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you recommend I use the structure in nav.html
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can definitely use that template, or any approach that achieves a split view. Another option is a button in the new nav bar that redirects to the 'Granted Prayers' list, though we'll need to create an appropriate icon for that. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the button option better. Creation of the new tab seems difficult because we need to feed the username into the context for the parent template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style refactors are looking good overall. I've refined the footer for the first prayers modal. We need to resolve the two remaining comments before we proceed with the merge.
This PR tackles #5111. It builds on #4956 by doing the following: