fix(find.py): Correct span calculation for short-form citations #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short-form citations were incorrectly identifying the span and full span of a citation. For example: And Twombly, 550 U. S., at 555 … Currently, when an antecedent guess is identified, it is not factored into the full span calculation. Additionally, the pin-cite is not correctly incorporated into the offset. This fix ensures both are properly accounted for.
grossir
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Seems like the "span_end" is not correct? Check output 17
text = "blah blah blah Adarand, 515 U.S., at 241 qdqwd lorem ipsum"
short = get_citations(text)[0]
In [15]: short
Out[15]: ShortCaseCitation('515 U.S., at 241', groups={'volume': '515', 'reporter': 'U.S.', 'page': '241'}, metadata=ShortCaseCitation.Metadata(parenthetical=None, pin_cite=None, year=None, court='scotus', antecedent_guess='Adarand'))
In [16]: text[short.full_span()[0]:short.full_span()[1]]
Out[16]: 'Adarand, 515 U.S., at 241'
# this last one is not working properly
In [17]: text[short.span()[0]:short.span()[1]]
Out[17]: '515 U.S., at '
|
@grossir that is the current functionality I believe. I didnt want to change that in this PR b |
The Eyecite Report 👁️Gains and LossesThere were 0 gains and 0 losses. Click here to see details.
Time Chart
Generated Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short-form citations were incorrectly identifying the span and full span of a citation.
For example:
Currently, when an antecedent guess is identified, it is not factored into the full span calculation. Additionally, the pin-cite is not correctly incorporated into the offset. This fix ensures both are properly accounted for.
This PR is meant to help address an issue discovered in identifying reference citations. The issue here is that
short case citations routinely develop an issue resolving the antecedent guess as a reference citation.