-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide UI recap-* UI elements from printed pages #355
Hide UI recap-* UI elements from printed pages #355
Conversation
.btn-group .btn+.btn, | ||
.btn-group .btn+.btn-group, | ||
.btn-group .btn-group+.btn, | ||
.btn-group .btn+.btn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure why these few lines have different line endings than the rest. I think my IDE just auto-trimmed them. Is that OK?
@media print { | ||
[class^="recap-"], [id^="recap-"] { /* Any class or ID that starts with `recap-` */ | ||
display: none; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual implementation
Looks OK to me. @ERosendo, yours for careful review. Thank you @arcataroger! |
( @arcataroger, so you know our process, here's what will happen next:
) |
Sounds good! No rush at all. I'll take a look at the other issues as time permits, but feel free to suggest some too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and the CSS selector patterns effectively match all extension-injected UI elements.
This summary outlines which CSS classes are targeted by the selectors and the corresponding UI elements they affect:
CSS Selector | CSS Class | UI Element |
---|---|---|
[class^="recap-"] | recap-email-banner | Banners to let users know about recap.email |
recap-email-banner-full | ||
recap-banner | Banner with a link to create a Docket Alert | |
Banner with a link to view the Docket on CL | ||
"Get this document for free" banner on the download page | ||
Warning about combined PDFs | ||
Warning about sealed document | ||
recap-inline | [R] icons on docket reports(district/appellate) | |
recap-inline-appellate | ||
[id^="recap-"] | recap-action-button | The recap button in appellate and district courts |
This simple CSS tweak should hide all the elements that we add, as long as they start with a CSS class or ID of
recap-*
. I haven't used the extension enough to be able to tell if this catches everything, but in my casual tests, it hid all the UI elements I could find.If we discover any that are missed, we should probably just add a
.recap-blahblah
class to them.