Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acms): Adds RECAP links and the RECAP button #374

Merged
merged 5 commits into from
May 14, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented May 2, 2024

This pull request introduces new methods for inserting the recap icon next to docket entry links whenever the corresponding document is accessible in the Recap archive and the RECAP button. The new helper functions are incorporated into the handleAcmsDocket method to use the existing mutationObserver and avoid repetition.

Here's a GIF showing the button and [R] icons:

Screen Recording 2024-05-02 at 12 54 11 PM

@ERosendo ERosendo changed the base branch from main to feat-adds-logic-to-handle-download-confirmation-page May 2, 2024 16:51
@ERosendo ERosendo marked this pull request as ready for review May 2, 2024 17:06
@ERosendo ERosendo requested a review from mlissner May 2, 2024 17:06
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. More docstrings though, please, then sure, let's get this merged.

Thank you!

);
};

const attachLinkToDocs = async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better docstring would be helpful here to future readers.

Base automatically changed from feat-adds-logic-to-handle-download-confirmation-page to main May 14, 2024 20:49
@ERosendo ERosendo requested a review from mlissner May 14, 2024 22:05
@mlissner mlissner merged commit 0939194 into main May 14, 2024
8 checks passed
@mlissner mlissner deleted the feat-adds-recap-links-and-the-recap-button branch May 14, 2024 22:09
@mlissner
Copy link
Member

Another step on the journey is in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants