Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpdisco: fixup advertisement of static routes #463

Merged
merged 2 commits into from
Dec 25, 2024
Merged

bgpdisco: fixup advertisement of static routes #463

merged 2 commits into from
Dec 25, 2024

Conversation

spolack
Copy link
Member

@spolack spolack commented Dec 25, 2024

Typical route as readvertised from saarbruecker (working):

2001:bf7:760:10fc::1/128 unreachable [bgpdisco_1_eth4_12 2024-12-24 from fe80::f29f:c2ff:fe0f:793d] * (100) [i]
	Type: BGP univ
	BGP.origin: IGP
	BGP.as_path: 
	BGP.next_hop: 2001:db8:: fe80::f29f:c2ff:fe0f:793d
	BGP.local_pref: 100
	BGP.fa [t]: 5b 20 5b 20 30 2c 20 22 73 77 69 74 63 68 30 5f 31 30 34 2e 73 65 67 65 6e 2d 63 6f 72 65 22 20 5d 20 5d

Local route advertised from static protocol (non-working)

bird> show route 2001:bf7:760:2201::2/128 all export bgpdisco_9_gre4_ak36 
Table v6_bgpdisco:
2001:bf7:760:2201::2/128 blackhole [static_bgpdisco_v6 2024-12-18] * (200)
	Type: static univ
	BGP.fa [t]: 5b 20 5b 20 30 2c 20 22 67 72 65 34 2d 6c 31 30 35 2e 73 61 61 72 62 72 75 65 63 6b 65 72 2d 67 77 22 20 5d 20 5d

See commit msg for more details.

@spolack
bgpdisco: bird config template: replace next-hop with filter
7454bb5 
The former way seemed only to apply to readvertised routes,
not to routes which were sourced from static protocol. Also
this reduces the footprint of the bgp message - before the
link local and global address were set as next hop. Now only
the single one configured in the filter.
@spolack
bgpdisco: bump version to 1.1
18c9e58
@pktpls
Copy link
Contributor

pktpls commented Dec 25, 2024

Nice small fix 👍

@pktpls pktpls merged commit 7c5f252 into main Dec 25, 2024
7 checks passed
@pktpls pktpls deleted the bgpdisco_fixup branch December 25, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spolack @pktpls