Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add ffac-ssid-changer #265

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

grische
Copy link
Contributor

@grische grische commented Oct 31, 2023

This new feature will turn the SSID from this node (random example): https://map.ffmuc.net/#!/en/map/50d4f75974f1
from muenchen.freifunk.net/augsburg to offline.ffmuc.net/ffmuc-50d4f75974f1.

While the current code will apply to other domains, like wertingen.freifunk.net/event to offline.ffmuc.net/whatevernodename, we can make the options domain-specific and respect wertingen (and ffdon).

Alternatively, we can change it to offline.freifunk.net/ffmuc-50d4f75974f1, but the domain http://offline.freifunk.net is currently unused. Do we care?

EDIT: edited domains to reflext new changes

Fixes #249.

@grische grische added backport legacy Backport to Legacy Branch backport next Backport to Next Branch labels Oct 31, 2023
@awlx
Copy link
Member

awlx commented Oct 31, 2023

I'd prefer to use offline.ffmuc.net and point that to something useful :).

@grische
Copy link
Contributor Author

grische commented Oct 31, 2023

@awlx good idea. I added a a PR to add offline.ffmuc.net. We can create our own documentation later, if we want to.

@grische
Copy link
Contributor Author

grische commented Oct 31, 2023

Tested on a FritzBox 7520/7530. Unplugged the cable before boot, saw the offline SSID, plugged the cable back in and saw the correct SSID.

@grische grische marked this pull request as ready for review October 31, 2023 17:05
@grische grische requested a review from a team as a code owner October 31, 2023 17:05
@grische grische merged commit 2096887 into freifunkMUC:stable Nov 1, 2023
28 checks passed
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Successfully created backport PR for legacy:

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Successfully created backport PR for next:

@grische grische deleted the feature/ffac-ssid-changer branch November 2, 2023 11:21
@grische grische removed the backport legacy Backport to Legacy Branch label Nov 2, 2023
grische added a commit that referenced this pull request Nov 3, 2023
grische added a commit that referenced this pull request Nov 3, 2023
@grische grische added backport legacy Backport to Legacy Branch stable labels Nov 3, 2023
@grische grische added this to the v2023.12.1 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport legacy Backport to Legacy Branch backport next Backport to Next Branch stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ssid-changer to stable firmware
3 participants