make fallback domain configurable #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T0biii
reviewed
May 20, 2024
unifi_respondd/config.py
Outdated
| @@ -73,6 +73,7 @@ def from_dict(cls, cfg: Dict[str, str]) -> "Config": | |||
| unicast_port=cfg["unicast_port"], | |||
| interface=cfg["interface"], | |||
| verbose=cfg["verbose"], | |||
| fallback_domain=cfg.get("fallback_domain", None), | |||
There was a problem hiding this comment.
maybe change None to unifi_respondd_fallback
There was a problem hiding this comment.
needs to be added also somewhere here:
https://github.com/grische/unifi_respondd/blob/feature/fallback-domain-configurable/unifi_respondd/config.py#L31-L45
There was a problem hiding this comment.
There was a problem hiding this comment.
Are you sure about unifi_respondd_fallback? Currently, it's ffmuc_unifi_respondd_fallback .
There was a problem hiding this comment.
as omada and the uisp_respondd uses also only x_respondd_fallback i think it would be the best
anyone can ajust it as they want :)
grische
force-pushed
the
feature/fallback-domain-configurable
branch
from
69748ea
to
757e4a2
Compare
GoliathLabs
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.