Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Primary key addition and title description changes #19

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

achingoyalcw
Copy link

@achingoyalcw achingoyalcw commented Jan 21, 2022


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

@achingoyalcw
Copy link
Author

  • fixes #

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

Issue: #21

@achingoyalcw
Copy link
Author

@roll Can you please review the changes that I did for addition of primary key to the fields and moving title and descriptions fields to the same level instead of showing below.

@roll
Copy link
Member

roll commented Feb 3, 2022

Thanks @achingoyalcw, sorry for the delay I'll be on it soon

@roll
Copy link
Member

roll commented Feb 5, 2022

Hi @achingoyalcw,

Can you please fix the tests (I think at least linting doesn't pass - npm run format to fix) and also please take a look at the error I have when trying npm start (the error exists if I run from this PR but it works on the main branch):

ModuleNotFoundError: Module not found: Error: Can't resolve 'react-json-editor-ajrm' in '/home/roll/projects/components/src/components'

@achingoyalcw
Copy link
Author

@roll Thanks for the review! But these are specific changes done as per requirement. Like

  1. Addition of primary key to the schema
  2. Showing constraints popup for each field to add any constraint.

Do you think I can merge this to main repo? Would that not affect existing users?

@roll
Copy link
Member

roll commented Feb 7, 2022

Hi @achingoyalcw,

I need to take a look to check whether we can merge it to the core but I failed to run it locally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Primary Key and moving Title and Description to field level
2 participants