Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPP_CELERY_TIMEZONE conf support #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abulte
Copy link

@abulte abulte commented Nov 23, 2020

  • I've added tests to cover the proposed changes

Changes proposed in this pull request:

  • If set, env var DPP_CELERY_TIMEZONE value will be passed to CELERY_TIMEZONE conf var, which makes the crontab feature easier to use (crontab set and executed in local timezone)

@coveralls
Copy link

coveralls commented Nov 23, 2020

Pull Request Test Coverage Report for Build 1169

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-8.5%) to 17.093%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datapackage_pipelines/celery_tasks/celery_common.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
.tox/py37-plyvel/lib/python3.7/site-packages/datapackage_pipelines/celery_tasks/celery_common.py 5 0%
.tox/py37-sqlite/lib/python3.7/site-packages/datapackage_pipelines/celery_tasks/celery_common.py 5 0%
Totals Coverage Status
Change from base Build 1166: -8.5%
Covered Lines: 1737
Relevant Lines: 10162

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants