Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Field Constraints" examples #1056

Merged
merged 12 commits into from
Nov 4, 2024
Merged

Conversation

roll
Copy link
Member

@roll roll commented Oct 28, 2024


It adds "Field Constraints" examples without changing the specification itself

Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2024

Deploying datapackage with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd38792
Status: ✅  Deploy successful!
Preview URL: https://4ef5e350.datapackage-6gp.pages.dev
Branch Preview URL: https://917-table-schema-constraint.datapackage-6gp.pages.dev

View logs

@roll roll requested a review from peterdesmet October 28, 2024 11:07
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions for changes, otherwise looks good.

Would be nice if we had the option for a side by side view of data and table schema.

content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
content/docs/standard/table-schema.mdx Outdated Show resolved Hide resolved
@roll
Copy link
Member Author

roll commented Nov 4, 2024

Thanks @peterdesmet!

Would be nice if we had the option for a side by side view of data and table schema.

Agree we need to try this; on the other hand we need to evaluate if it adds to much editing complexity to markdown (in my opinion the closer to bare markdown the better)

@roll roll merged commit dc946e8 into main Nov 4, 2024
2 checks passed
@roll roll deleted the 917/table-schema-constraint-examples branch November 4, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples of Table Schema constraints
2 participants