Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the arm download name #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the arm download name #139

wants to merge 1 commit into from

Conversation

dzervas
Copy link
Contributor

@dzervas dzervas commented Jul 27, 2024

On armhf target frida-build tries to download the package with suffix armhf which doesn't exist. It should be arm instead

@s1341
Copy link
Contributor

s1341 commented Jul 28, 2024

Thanks. Please fix CI.

@dzervas
Copy link
Contributor Author

dzervas commented Jul 28, 2024

I didn't change anything related to the CI failure

It broke due to the new rust 1.80 which checks for cfg settings (but doc_cfg I think is valid)

I'm not sure how to fix it cleanly

@s1341
Copy link
Contributor

s1341 commented Jul 29, 2024

Ok. I will try to fix in a different PR.

@s1341
Copy link
Contributor

s1341 commented Jul 30, 2024

Please rebase on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzervas @s1341