Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes wrong order of pre-release tags #274

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

evilru
Copy link

@evilru evilru commented Sep 11, 2024

Replaced the package semver-compare with compare-versions.

semver-compare dosn't have support for pre-release tags and does not sort it properly
where compare-versions does.

Added an e2e test covering the issue I run into during init.

@evilru evilru force-pushed the fix/order-of-pre-release-tags branch from 254d36e to d5161b4 Compare September 11, 2024 22:29
replace npm package semver-compare with compare-versions
it has support for pre-release tags
This verifies that the recent change from npm package
semver-compare to compare-versions
solves wrong order of pre-release tags
@evilru evilru force-pushed the fix/order-of-pre-release-tags branch from d5161b4 to 93eb682 Compare September 11, 2024 22:59
@evilru evilru force-pushed the fix/order-of-pre-release-tags branch from 93eb682 to cb0965a Compare September 11, 2024 23:18
@evilru evilru changed the title Fixes wrong order of pre-release tags 🐛 Fixes wrong order of pre-release tags Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant